Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile wallet feature parity #29

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Mobile wallet feature parity #29

wants to merge 30 commits into from

Conversation

soerenbf
Copy link
Contributor

@soerenbf soerenbf commented Sep 13, 2024 •
edited
Loading

Changes

  • Adds support for deriving encryption keys + combining and decrypting encrypted amounts
  • Add support for ID2.5 proofs and verifiable credentials + presentations

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@soerenbf soerenbf self-assigned this Sep 13, 2024
@soerenbf soerenbf mentioned this pull request Oct 2, 2024
Open
5 tasks
@soerenbf soerenbf requested a review from DOBEN October 2, 2024 15:04
@soerenbf soerenbf marked this pull request as ready for review October 3, 2024 07:28
DOBEN
DOBEN reviewed Oct 7, 2024
View reviewed changes
build.rs Show resolved Hide resolved
src/id_proofs.rs Outdated Show resolved Hide resolved
src/id_proofs.rs Outdated Show resolved Hide resolved
src/id_proofs.rs Outdated Show resolved Hide resolved
src/id_proofs.rs Outdated Show resolved Hide resolved
src/web3id.rs Show resolved Hide resolved
src/web3id.rs Show resolved Hide resolved
src/web3id.rs Outdated Show resolved Hide resolved
src/web3id.rs Outdated Show resolved Hide resolved
src/web3id.rs Show resolved Hide resolved
@soerenbf soerenbf requested a review from DOBEN October 8, 2024 09:37
DOBEN
DOBEN approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
src/id_proofs.rs Outdated
)
.context("Could not produce proof.")
.map_err(|e| e.to_call_failed(fn_name.to_string()))?;
VersionedIdentityProof::try_from(concordium_base::common::Versioned::new(VERSION_0, proof))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the purpose of this VERSION_0. Will it always be 0 for now or is it related to the proofV2 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the JS SDK, the proof produced for VERSION_0 is ProofVersion::Version1, so the version should (probably) be bumped. The proof version is needed to verify the proof.. I can't find any documentation pointing to a link between a Versioned<Proof> and ProofVersion 🤷 . Bare in mind this is for the "old" ID proofs and is not used for ID2.5 verifiable credentials so it probably will not be updated.

Have you worked with ID proofs versioned this way?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERSION_0 for ProofVersion::Version1
and
VERSION_1 for ProofVersion::Version2
makes sense, so I am fine if we go with that.

@soerenbf soerenbf force-pushed the mobile-wallet-feature-parity branch from fd531b5 to ce0a497 Compare October 8, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DOBEN DOBEN DOBEN approved these changes

Assignees

@soerenbf soerenbf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soerenbf @DOBEN